Skip to content

Add support for using run_model_on_task simply#888

Merged
mfeurer merged 3 commits intoopenml:developfrom
m7142yosuke:simplify_run_model_on_task_867
Nov 22, 2019
Merged

Add support for using run_model_on_task simply#888
mfeurer merged 3 commits intoopenml:developfrom
m7142yosuke:simplify_run_model_on_task_867

Conversation

@m7142yosuke
Copy link
Contributor

@m7142yosuke m7142yosuke commented Nov 21, 2019

Reference Issue

Addresses #867

What does this PR implement/fix? Explain your changes.

Allow to sepecify task_id(int or str) in run_model_on_task directly.
(i.e. you can use run_model_on_task(clf, task_id) and run_model_on_task(clf, task))

How should this PR be tested?

Compare the results of

from sklearn import ensemble
from openml import tasks, runs

clf = ensemble.RandomForestClassifier()
run = runs.run_model_on_task(clf, 3954)
run.publish()

and

from sklearn import ensemble
from openml import tasks, runs

clf = ensemble.RandomForestClassifier()
task = tasks.get_task(3954)
run = runs.run_model_on_task(clf, task)
run.publish()

mfeurer
mfeurer approved these changes Nov 22, 2019
View reviewed changes
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, very much appreciated!

@mfeurer mfeurer merged commit d5e46fe into openml:develop Nov 22, 2019
@codecov-io
Copy link

codecov-io commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #888 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #888      +/-   ##
==========================================
+ Coverage    88.49%   88.5%   +0.01%     
==========================================
  Files           37      37              
  Lines         4319    4324       +5     
==========================================
+ Hits          3822    3827       +5     
  Misses         497     497
Impacted Files Coverage Δ
openml/runs/functions.py 83.1% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7e740...39d6baa. Read the comment docs.

@m7142yosuke m7142yosuke deleted the simplify_run_model_on_task_867 branch November 22, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m7142yosuke @codecov-io @mfeurer